refactor(execution, native_blockifier): move pre_process_block to PyB… #1422
Conversation
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
3c59ae1
to
0c8bc0d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## barak/block_executor/transaction_executor_finalize #1422 +/- ##
======================================================================================
+ Coverage 70.39% 70.45% +0.05%
======================================================================================
Files 60 60
Lines 7780 7774 -6
Branches 7780 7774 -6
======================================================================================
Hits 5477 5477
+ Misses 1872 1866 -6
Partials 431 431 ☔ View full report in Codecov by Sentry. |
barak-b-starkware
force-pushed
the
barak/block_executor/transaction_executor_finalize
branch
from
8f16aab
to
d8cefb4
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
0c8bc0d
to
c653a44
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/transaction_executor_finalize
branch
from
d8cefb4
to
f7c6093
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
c653a44
to
586ecbe
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @barak-b-starkware and @Yoni-Starkware)
a discussion (no related file):
This might also collide with #1387, please make sure you minimize conflicts.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware and @Yoni-Starkware)
a discussion (no related file):
Python PR?
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware)
…ute() work w/o Py objects
barak-b-starkware
force-pushed
the
barak/block_executor/transaction_executor_finalize
branch
from
f7c6093
to
43fbd6b
Compare
…lize() work without Py objects
barak-b-starkware
force-pushed
the
barak/block_executor/transaction_executor_finalize
branch
from
43fbd6b
to
1ba0733
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
586ecbe
to
d8abfd0
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware)
barak-b-starkware
force-pushed
the
barak/block_executor/transaction_executor_finalize
branch
7 times, most recently
from
6bbb895
to
a97ae89
Compare
barak-b-starkware
dismissed
Yoni-Starkware’s stale review
The base branch was changed.
…lockExecutor
This change is